Amarok-git

  • Filter
Rick W. Chen
Fix current track applet's handling of playback stopped state
If the context dock is polished after playback starts, it will end up in
the stopped state mode (with last played tracks showing, and also last
added albums in the albums applet).

This fixes that and also removes a timer used for switching states. Now
the current track applet (and hence the albums applet) will be more
responsive on data updates.
Rick W. Chen
Do not close the cover found dialog if download is cancelled or failed
Mark Kretschmann
ILIBS, begone! (typo fail)
Leo Franchi
File Name->Filename, not consistent with the same dialog, but it's an already-translated string while File Name is not and we're in string freeze
changed EditFilterDialog.ui
Mark Kretschmann
Make all unit tests build with the Gold Linker.
Gold is stricter than the GNU linker, so there were a lot of link targets
missing. Also, some targets had spelling errors.

Happy lightning fast linking ;)
Jacob Vigeveno
Replace class forward declaration of QXmlStreamReader with #include to build on OS X reorder header
Martin Blumenstingl
LabelsApplet: trying to fix a crash in the applet's destructor. Also initialized all pointers in the constructor to 0.
CCBUG: 248553
Mark Kretschmann
Make Amarok build with the Gold linker.
Our imported classes KRatingWidget and KRatingPainter (from KDElibs/Nepomuk)
need to be in a separate namespace to make Gold happy.

Thanks to Pino for the hint.
Mark Kretschmann
Revert "Remove copies of KRatingWidget and KRatingPainter, use KDE classes."
This reverts commit d7986c253fa0717ed4837a6b3b5e902fb203a2af.

Too bad: Nepomuk is optional, so we can't rely on its presence, even though
these classes are in KDElibs. So the revert fixes this case.
However, without this patch Amarok won't build with the Gold Linker any more :(
Mark Kretschmann
Remove copies of KRatingWidget and KRatingPainter, use KDE classes.
These classes have been in KDElibs (Nepomuk) since KDE 4.1, so there
is no point in bundling our own copies. Our crufty classes must have
been around from KDE 4.0 days :)
Rick W. Chen
Add informative debugging info on daap service availability
Rick W. Chen
Prevent SqlPodcastProvider from creating CollectionManager instance on shutdown
SqlPodcastProvider calls updateInDb() in its dtor, which in turn calls
CollectionManager::instance() for savng episode/channel info into the db.
Since the playlist manager is destroyed after the collection manager, an
instance of the latter is created again, and slowing down shutdown.
changed App.cpp
Ralf Engels
Fix test case after removing abortMetaDataUpdate
Ralf Engels
Fix covers no longer displayed and album not longer renamed if you rename it together with artist. Both were problems in the previous patches.
Rick W. Chen
Fix fetching audiocd cddb info with localized amarok
We are using the audiocd kioslave to retrieve the cddb info for us. It is
put under "audiocd:/Information/CDDB Information.txt" but the url would be
invalid if the strings are localized.
Daniel Faust
yet another fix for the labels applet height
Marius Helf
changed Filename to File Name in EditFilterDialog to be consistent to the string File Size in the same dialog
changed EditFilterDialog.ui
Rick W. Chen
Fix double-clicking items in collection browser in double-click mode
Noted by Frank Steinmetzger:

the collection cannot be expanded in double-click mode, instead it is
added to the playlist (which takes lots of time if you have +34000
titles in it) This is especially annoying because sometimes the
collection is collapsed by default, so there is no way to actually see
anything of it.
Ralf Engels
SqlMeta copy cover image when renaming an album. Fix BUG 203211
Ralf Engels
SqlMeta.cpp notify all observers if metadata changes
Just invalidating the cache is not enough. Also the observers should be notified.
Ralf Engels
Remove unused abortMetaDataUpdate.
I can't imagine how this can be ever usefull. And even if it were then
the caller could re-do it on it's own.
The only real implementation of this function was in SqlMeta.cpp
Rick W. Chen
Bypass QSFPM in playlist browser merged view
This fixes a crash when adding new folders repeatedly in saved playlist /
podcast browsers.
Rick W. Chen
Set numbered names properly when adding new folders in playlist browsers